Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing React/RCTBridgeModule.h #138

Closed
wants to merge 1 commit into from
Closed

Conversation

iegik
Copy link

@iegik iegik commented Sep 4, 2017

If somewhere in code already was import by file name only:

  #import "RCTBridgeModule.h"

Next import will fail if you try to import by another method:

  #import <React/RCTBridgeModule.h>

Becouse paths are different, but import by filename will work every time.

@mmerickel
Copy link

I can confirm that this fixes my issues on react-native 0.48.1.

@MatthieuPeyrot
Copy link

+1

@MoOx
Copy link
Collaborator

MoOx commented Sep 8, 2017

@yonahforst do you need any help to release this?

@TikiTDO
Copy link
Contributor

TikiTDO commented Sep 12, 2017

This commit wasn't quite doing it for me, so I used it as a basis for a standardized approach across all the affected files, please refer to this commit for an example. I can submit a PR if interested.

@ujwal-setlur
Copy link

@TikiTDO, I think you should raise a PR. I see another PR also addressing this, but its implementation is a bit different.

@grootendorste
Copy link

grootendorste commented Sep 15, 2017

This fixes my problem on React-Native v0.48.2. Can this get merged in?

@hugo-retro
Copy link

This fixes my issue when upgrading to React-native 0.48.2 from 0.47.2

Node: 8.4.0
npm: 4.6.1
react-native-cli: 2.0.1

@MoOx
Copy link
Collaborator

MoOx commented Sep 15, 2017

Maybe we can make it easy to review for @yonahforst and close 2 or this 3 PRs?

It seems #146 is rock solid, but I am not very comfortable yet with obj-c.

@MoOx MoOx mentioned this pull request Sep 15, 2017
@grootendorste
Copy link

So if @yonahforst is happy with #146 then #138 and #139 can be closed, that would be great.

zain added a commit to opendoor-labs/react-native-config that referenced this pull request Sep 21, 2017
yonahforst added a commit that referenced this pull request Sep 26, 2017
Fix RN import priority, favoring newest version of RN (Adds to #138 and #139)
@yonahforst
Copy link
Collaborator

closed in favor of #146. Thanks everyone for your comments. And thanks to @iegik and @huhuanming for #138 & #139

@yonahforst yonahforst closed this Sep 26, 2017
@yonahforst yonahforst reopened this Sep 28, 2017
@yonahforst yonahforst closed this Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants